I'd be thinking about downsizing in the future in order to give them money rather than building a Granny flat. The downsides have been articulated above. If you now have a house that is suitable for 4 people you don't need the same space when they move out. I agree with your sentiment on helping your children out.